Merged
Conversation
fmigneault
added
the
feature/docker
github-actions
bot
added
ci/operations
…blem link anchors while validating pages themselves
fmigneault
force-pushed
the
fix-docker-worker
branch
from
a6befbe to
f0d9aff
Compare
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 84.39% 84.38% -0.01%
==========================================
Files 79 79
Lines 17596 17601 +5
Branches 2670 2670
==========================================
+ Hits 14850 14853 +3
- Misses 2017 2019 +2
Partials 729 729
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker build issue identified in https://github.com/crim-ca/weaver/actions/runs/5476798191/jobs/9974868828?pr=542
Fixes
Since the CI fails with either combination of those fixes individually (docker build fail or lint checks fail), combine them all in one.
weaver-workerimage due to unresolveddocker-ce-clipackage.Installation is updated according to the reference documentation (https://docs.docker.com/engine/install/debian/).
bytesinstead ofstr) for some handlers inopen_module_resource_file.jsonschema.validators.RefResolverreference injsonschema>=4.18.0caused by refactor(see https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst#v4180
and Replace
$ref&$dynamicRefsupport /RefResolverwith the new referencing library python-jsonschema/jsonschema#1049).